Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Fix anchor for arm_sve.h. #206

Merged
merged 1 commit into from
Jul 4, 2022
Merged

[main] Fix anchor for arm_sve.h. #206

merged 1 commit into from
Jul 4, 2022

Conversation

fpetrogalli
Copy link
Contributor

Previously, all the references to the section <arm_sve.h> were
missed in the web version of the specs because Jenkins was generating
the anchor as arm_sveh instead of arm_sve.h.

Checklist: (mark with X those which apply)

  • If an issue reporting the bug exists, I have mentioned it in the
    PR (do not bother creating the issue if all you want to do is
    fixing the bug yourself).
  • I have added/updated the SPDX-FileCopyrightText lines on top
    of any file I have edited. Format is SPDX-FileCopyrightText: Copyright {year} {entity or name} <{contact informations}>
    (Please update existing copyright lines if applicable. You can
    specify year ranges with hyphen , as in 2017-2019, and use
    commas to separate gaps, as in 2018-2020, 2022).
  • I have updated the Copyright section of the sources of the
    specification I have edited (this will show up in the text
    rendered in the PDF and other output format supported). The
    format is the same described in the previous item.
  • I have run the CI scripts (if applicable, as they might be
    tricky to set up on non-*nix machines). The sequence can be
    found in the contribution
    guidelines
    . Don't
    worry if you cannot run these scripts on your machine, your
    patch will be automatically checked in the Actions of the pull
    request.
  • I have added an item that describes the changes I have
    introduced in this PR in the section Changes for next
    release
    of the section Change Control/Document history
    of the document. Create Changes for next release if it does
    not exist. Notice that changes that are not modifying the
    content and rendering of the specifications (both HTML and PDF)
    do not need to be listed.
  • When modifying content and/or its rendering, I have checked the
    correctness of the result in the PDF output (please refer to the
    instructions on how to build the PDFs
    locally
    ).
  • The variable draftversion is set to true in the YAML header
    of the sources of the specifications I have modified.
  • Please DO NOT add my GitHub profile to the list of contributors
    in the README page of the project.

Previously, all the references to the section `<arm_sve.h>` were
missed in the web version of the specs because Jenkins was generating
the anchor as `arm_sveh` instead of `arm_sve.h`.
@fpetrogalli fpetrogalli requested a review from rsandifo-arm July 4, 2022 09:07
@rsandifo-arm
Copy link
Contributor

Bah, would be nice if this stuff was standardised :-)

@rsandifo-arm rsandifo-arm merged commit 6eb8516 into ARM-software:main Jul 4, 2022
@fpetrogalli
Copy link
Contributor Author

Bah, would be nice if this stuff was standardised :-)

Totally agree. I chose Jekyll for generating the website, but it makes it difficult to verify the outcome because we don't explicitly run any CI with it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants