Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style: 상단 네비게이션 메뉴에 Divider 추가 및 프로젝트섹션 내 셀렉터 id 수정 #27

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Style: 상단 네비게이션 메뉴에 Divider 추가 및 프로젝트섹션 내 셀렉터 id 수정 #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/Header/Header.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ const Header = () => {
<S.Nav>
<S.NavItem onClick={() => scrollToSection('aboutApps')}>APPS 소개</S.NavItem>
<S.NavItem onClick={() => scrollToSection('projectsSection')}>프로젝트 소개</S.NavItem>
<S.NavDivider>|</S.NavDivider>
<S.NavItem onClick={handleGitHubClick}>깃허브</S.NavItem>
</S.Nav>
</S.Inner>
Expand Down
2 changes: 2 additions & 0 deletions src/components/Header/Header.style.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,5 @@ export const NavItem = styled.a`
color: white;
}
`;

export const NavDivider = styled.text``;
4 changes: 2 additions & 2 deletions src/components/ProjectsSection/ProjectsSection.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,10 +106,10 @@ const PROJECT_CATEGORY_LIST = [
const ProjectsSection = () => {
return (
<S.Section>
<S.TopBackground />
<S.TopBackground id="projectsSection" />
<S.BottomBackground />
<S.SectionInner>
<S.SectionTitle id="projectsSection">프로젝트 소개</S.SectionTitle>
<S.SectionTitle>프로젝트 소개</S.SectionTitle>
<S.SectionNav>
{PROJECT_CATEGORY_LIST.map(({ id, title }) => (
<S.SectionNavItem key={id} href={`#${id}`}>
Expand Down
4 changes: 2 additions & 2 deletions src/pages/HomePage/HomePage.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ const HomePage = () => {
</S.MessageSectionInner>
</S.MessageSection>

<S.AboutAppsSection>
<S.AboutAppsSection id="aboutApps">
<S.AboutAppsSectionInner>
<AnimationOnScroll animateIn="animate__fadeInUp" animateOnce={true}>
<S.SectionTitle id="aboutApps">{'APPS 소개'}</S.SectionTitle>
<S.SectionTitle>{'APPS 소개'}</S.SectionTitle>
<S.SectionDescription>
APPS는 모바일 앱&웹 프로그래밍 동아리로,
<br /> 기술과 아이디어를 통해 프로젝트를 진행하며
Expand Down