Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.20.1 #591

Merged
merged 18 commits into from
Jun 15, 2023
Merged

1.20.1 #591

merged 18 commits into from
Jun 15, 2023

Conversation

TylerS1066
Copy link
Contributor

@TylerS1066 TylerS1066 commented Jun 4, 2023

Describe in detail what your pull request accomplishes

This PR removes 1.14.4 and 1.17.1 support and will add support for 1.20.1.

Checklist

  • Tested

@TylerS1066
Copy link
Contributor Author

Spigot still has serious bugs with their API and hanging signs. They only seem to work in 1/2 directions, and for some reasons cruise signs don't work while ascend signs do.

Here's a status on the various Movecraft signs:

  • Ascend: Works
  • Contacts: Works
  • Craft: Works
  • Cruise: Does not work
  • Descend: Does not fit on hanging signs.
  • Helm: Works
  • Move: TBD
  • Name: Doesn't seem to be working?
  • Pilot: Not sure yet
  • Relative Move:
  • Release: Works
  • Remote: Works
  • Scuttle: Works
  • Speed: Works
  • Status: Works
  • Subcraft Rotate: Does not fit on hanging signs.
  • Teleport: TBD

@TylerS1066 TylerS1066 marked this pull request as ready for review June 14, 2023 22:16
@TylerS1066 TylerS1066 changed the title 1.20 1.20.1 Jun 15, 2023
@TylerS1066
Copy link
Contributor Author

As an update, wall hanging signs properly work the same as wall signs now, and hanging signs work just like normal standing signs.

@TylerS1066 TylerS1066 merged commit cb00e4b into main Jun 15, 2023
@TylerS1066 TylerS1066 deleted the 1.20 branch June 15, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant