Fixes to RequiredBlockEntry #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerS1066
approved these changes
Dec 16, 2021
This was referenced Dec 22, 2021
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe in detail what your pull request accomplishes
This PR fixes two issues related to the
RequiredBlockEntryclass.Firstly, it fixes integer division being used when calculating
blockPercent. This led to imprecision that could prevent crafts which just about satisfied the flyblock requirements from being piloted.Secondly, it fixes the
sinkPercentcraft flag. Currently, a craft will sink ifblockPercent * sinkPercent < min.Suppose:
blockPercent(the percentage of the craft made from the flyblock) is6.0sinkPercentis set to80.0in a craft file (so is0.8in the code),minfor this flyblock is5.0.Then
blockPercent * sinkPercentwill be4.8, and the craft will always sink immediately after being piloted. The PR fixes the condition so that the craft will only sink ifblockPercent < min * sinkPercent, which IIRC is what it previously was.Related issues:
N/A
Checklist