Update test_all_configurations.sh #2609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrabaud
reviewed
Feb 11, 2025
| ./aom.cmd | ||
| rm -rf dav1d | ||
| cp dav1d.cmd dav1d_sanitized.cmd | ||
| sed -i 's/meson setup \(.*\) \.\./meson setup \1 '"-Db_sanitize=${SANITIZER} -Db_lundef=false"' ../g' dav1d_sanitized.cmd |
There was a problem hiding this comment.
This is weird: we have to patch meson to make it aware we are using sanitizers in the CI, cf
There was a problem hiding this comment.
This is mostly to check that everything builds correctly and that all tests pass, so if dav1d is not sanitized in this script that's alright in my opinion. It is already tested in the CI as you mentioned.
It would be good to have a CMake option for that in libavif/CMakeLists.txt, if feasible.
vrabaud
approved these changes
Feb 12, 2025
[skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.