Add AVIF_ENABLE_EXPERIMENTAL_EXTENDED_PIXI #2591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add experimental support for PixelInformationProperty syntax from HEIF 3rd Ed. Amd2 behind a compilation flag.
maryla-uc
approved these changes
Feb 3, 2025
maryla-uc
approved these changes
Feb 4, 2025
wantehchang
reviewed
Feb 11, 2025
| #if defined(AVIF_ENABLE_EXPERIMENTAL_EXTENDED_PIXI) | ||
| // Use the full syntax of the PixelInformationProperty from HEIF 3rd edition Amendment 2. | ||
| // WARNING: Experimental feature. Produces files that may be incompatible with older decoders. | ||
| AVIF_HEADER_FULL_WITH_EXTENDED_PIXI, |
There was a problem hiding this comment.
The use of the extended 'pixi' box should not be encoded in the header format's name, otherwise we will need to add new header formats combinatorially if another box is extended.
For a hypothetical example, suppose the 'meta' box is extended in the future. Then we will need to add not only AVIF_HEADER_FULL_WITH_EXTENDED_META but also AVIF_HEADER_FULL_WITH_EXTENDED_META_AND_EXTENDED_PIXI.
There are two alternatives that avoid the combinatorial growth of header formats:
- Add a new boolean field
useExtendedPixitoavifEncoderinstead. - Encode the version of HEIF in the new header format, e.g.,
AVIF_HEADER_FULL_ED3_AMD2.
There was a problem hiding this comment.
Another alternative: #2612
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add experimental support for PixelInformationProperty syntax from HEIF 3rd Ed. Amd2 behind a compilation flag.