Check that the gain map max is >= gain map min. #2580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maryla: I am really sorry. I remember I reviewed this pull request but somehow got distracted and forgot to come back. I will review it tomorrow. |
|
No worries, I completely forgot about this PR as well... |
wantehchang
reviewed
Feb 11, 2025
wantehchang
reviewed
Feb 11, 2025
| [max_n, max_d](int32_t min_n) { | ||
| // For simplicity, use the same denominator for both fractions. | ||
| // This does not cover all possible fractions but makes it easy | ||
| // to guarantee that the first fraction is smaller. |
There was a problem hiding this comment.
Nit: Add "than or equal to the second one", or change "smaller" to "not bigger".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2573