FOR TESTING ONLY: test windows clang-cl workflow #2288
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It passes so I guess we need more warning flags? |
|
I am also puzzled why it passed. I think it is because Chrome enables C++ version >= 17. We enable C++14. I just checked Google's Foundational C++ Support table. It supports C++ >= 14. So we should not enable C++17 yet. Our only option is to set For now, let's just import into Chrome frequently. |
0dd4335 to
2918f21
Compare
794720c to
17edf54
Compare
|
This pull request was just a test. Test completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-cl compilation should fail.