read.c: Treat version 1 as version 0 for stsd box #2181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wantehchang
reviewed
May 30, 2024
There was a problem hiding this comment.
Vignesh: I suggest two changes.
@y-guyon We should think about whether an unsupported version should be reported as an error or silently ignored. (This pull request follows our current policy of reporting an unsupported version as an error.)
According to 8.5.2.3 of ISO/IEC 14496-12: version is set to zero. A version number of 1 shall be treated as a version of 0.
f0b58d7 to
56d522f
Compare
I do not see any problem with keeping the current policy. It can also be on a case-by-case basis once we encounter issues requiring more leniency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to 8.5.2.3 of ISO/IEC 14496-12:
version is set to zero. A version number of 1 shall be treated as
a version of 0.