Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetSeedDataDirs: allow TEST_DATA_DIRS to be -D defined #2162

Merged
merged 2 commits into from
May 21, 2024

Conversation

jzern
Copy link
Collaborator

@jzern jzern commented May 18, 2024

This allows build/test environments to set the path if they are unable
influence the environment. This is based on the implementations in
libvpx and libaom.

Bug: https://crbug.com/329464135

@jzern jzern requested a review from y-guyon May 18, 2024 02:05
@jzern
Copy link
Collaborator Author

jzern commented May 18, 2024

Looks like ubuntu-latest might need some additional packages now.

This allows build/test environments to set the path if they are unable
influence the environment. This is based on the implementations in
libvpx and libaom.

Bug: https://crbug.com/329464135
@jzern jzern force-pushed the TEST_DATA_DIRS-define branch from 0b7352d to 5ffaa03 Compare May 20, 2024 22:39
Copy link
Collaborator

@y-guyon y-guyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comments, feel free to submit as is to save time

tests/gtest/avif_fuzztest_helpers.cc Outdated Show resolved Hide resolved
tests/gtest/avif_fuzztest_helpers.cc Outdated Show resolved Hide resolved
@jzern jzern merged commit d369ffb into AOMediaCodec:main May 21, 2024
13 checks passed
@jzern jzern deleted the TEST_DATA_DIRS-define branch May 21, 2024 20:40
jzern added a commit to jzern/libavif that referenced this pull request Jun 7, 2024
…iaCodec#2162)"

This reverts commit d369ffb.

This change was meant to allow the fuzz tests to be run by Chrome's
ClusterFuzz, but the source tree is unavailable in the fuzzer
environment and there is no way to copy the data currently. Adding the
ability for the latter was also discouraged by the security/clusterfuzz
team.
jzern added a commit that referenced this pull request Jun 7, 2024
…" (#2196)

This reverts commit d369ffb.

This change was meant to allow the fuzz tests to be run by Chrome's
ClusterFuzz, but the source tree is unavailable in the fuzzer
environment and there is no way to copy the data currently. Adding the
ability for the latter was also discouraged by the security/clusterfuzz
team.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants