Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gcc to 13 for the CI. #1886

Merged
merged 1 commit into from
Dec 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/ci-disable-gtest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,16 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest]
include:
- runs-on: ubuntu-latest
compiler: gcc
gcc: 13

steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- name: Set GCC & G++ 10 compiler (on Linux)
- name: Set GCC & G++ compiler (on Linux)
if: runner.os == 'Linux'
run: echo "CC=gcc-10" >> $GITHUB_ENV && echo "CXX=g++-10" >> $GITHUB_ENV
run: echo "CC=gcc-${{matrix.gcc}}" >> $GITHUB_ENV && echo "CXX=g++-${{matrix.gcc}}" >> $GITHUB_ENV
- uses: actions/setup-python@61a6322f88396a6271a6ee3565807d608ecaddd1 # v4.7.0
with:
python-version: '3.x'
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/ci-linux-golden-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,15 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest]
include:
- runs-on: ubuntu-latest
compiler: gcc
gcc: 13

steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- name: Set GCC & G++ 10 compiler (on Linux)
run: echo "CC=gcc-10" >> $GITHUB_ENV && echo "CXX=g++-10" >> $GITHUB_ENV
- name: Set GCC & G++ compiler (on Linux)
run: echo "CC=gcc-${{matrix.gcc}}" >> $GITHUB_ENV && echo "CXX=g++-${{matrix.gcc}}" >> $GITHUB_ENV
- uses: actions/setup-python@61a6322f88396a6271a6ee3565807d608ecaddd1 # v4.7.0
with:
python-version: '3.x'
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/ci-unix-shared-installed.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,16 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest]
include:
- runs-on: ubuntu-latest
compiler: gcc
gcc: 13

steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- name: Set GCC & G++ 11 compiler (on Linux)
- name: Set GCC & G++ compiler (on Linux)
if: runner.os == 'Linux'
run: echo "CC=gcc-11" >> $GITHUB_ENV && echo "CXX=g++-11" >> $GITHUB_ENV
run: echo "CC=gcc-${{matrix.gcc}}" >> $GITHUB_ENV && echo "CXX=g++-${{matrix.gcc}}" >> $GITHUB_ENV

- name: Cache external dependencies
id: cache-ext
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/ci-unix-shared-local.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,18 @@ jobs:
matrix:
os: [ubuntu-latest, macos-latest]
libyuv: [OFF, LOCAL]
include:
- runs-on: ubuntu-latest
compiler: gcc
gcc: 13

name: build-shared-local (${{ matrix.os }}, libyuv ${{ matrix.libyuv }})

steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- name: Set GCC & G++ 10 compiler (on Linux)
- name: Set GCC & G++ compiler (on Linux)
if: runner.os == 'Linux'
run: echo "CC=gcc-10" >> $GITHUB_ENV && echo "CXX=g++-10" >> $GITHUB_ENV
run: echo "CC=gcc-${{matrix.gcc}}" >> $GITHUB_ENV && echo "CXX=g++-${{matrix.gcc}}" >> $GITHUB_ENV
- uses: actions/setup-python@61a6322f88396a6271a6ee3565807d608ecaddd1 # v4.7.0
with:
python-version: '3.x'
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/ci-unix-static-av2.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,16 @@ jobs:
fail-fast: false
matrix:
also-enable-av1-codecs: [OFF, LOCAL] # On top of enabling AV2 codecs.
include:
- runs-on: ubuntu-latest
compiler: gcc
gcc: 13

steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- name: Set GCC & G++ 10 compiler (on Linux)
- name: Set GCC & G++ compiler (on Linux)
if: runner.os == 'Linux'
run: echo "CC=gcc-10" >> $GITHUB_ENV && echo "CXX=g++-10" >> $GITHUB_ENV
run: echo "CC=gcc-${{matrix.gcc}}" >> $GITHUB_ENV && echo "CXX=g++-${{matrix.gcc}}" >> $GITHUB_ENV
- uses: actions/setup-python@61a6322f88396a6271a6ee3565807d608ecaddd1 # v4.7.0
with:
python-version: '3.x'
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/ci-unix-static.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,16 @@ jobs:
matrix:
os: [ubuntu-latest, macos-latest]
build-type: [Release, Debug]
include:
- runs-on: ubuntu-latest
compiler: gcc
gcc: 13

steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- name: Set GCC & G++ 10 compiler (on Linux)
- name: Set GCC & G++ compiler (on Linux)
if: runner.os == 'Linux'
run: echo "CC=gcc-10" >> $GITHUB_ENV && echo "CXX=g++-10" >> $GITHUB_ENV
run: echo "CC=gcc-${{matrix.gcc}}" >> $GITHUB_ENV && echo "CXX=g++-${{matrix.gcc}}" >> $GITHUB_ENV
- uses: actions/setup-python@61a6322f88396a6271a6ee3565807d608ecaddd1 # v4.7.0
with:
python-version: '3.x'
Expand Down
6 changes: 3 additions & 3 deletions src/utils.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ float avifRoundf(float v)

uint16_t avifHTONS(uint16_t s)
{
uint16_t result;
uint16_t result = 0;
uint8_t * data = (uint8_t *)&result;
data[0] = (s >> 8) & 0xff;
data[1] = (s >> 0) & 0xff;
Expand All @@ -37,7 +37,7 @@ uint16_t avifCTOHS(uint16_t s)

uint32_t avifHTONL(uint32_t l)
{
uint32_t result;
uint32_t result = 0;
uint8_t * data = (uint8_t *)&result;
data[0] = (l >> 24) & 0xff;
data[1] = (l >> 16) & 0xff;
Expand All @@ -60,7 +60,7 @@ uint32_t avifCTOHL(uint32_t l)

uint64_t avifHTON64(uint64_t l)
{
uint64_t result;
uint64_t result = 0;
uint8_t * data = (uint8_t *)&result;
data[0] = (l >> 56) & 0xff;
data[1] = (l >> 48) & 0xff;
Expand Down
Loading