List AVIF_COLOR_PRIMARIES_SRGB after BT709 #1869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This order suggests that AVIF_COLOR_PRIMARIES_BT709 is the main name of the constant and AVIF_COLOR_PRIMARIES_SRGB is an alias. The association of color_primaries value 1 with BT.709 is well known.
wantehchang
commented
Dec 12, 2023
| AVIF_COLOR_PRIMARIES_BT709 = 1, | ||
| AVIF_COLOR_PRIMARIES_SRGB = 1, |
There was a problem hiding this comment.
Note that I didn't reorder AVIF_TRANSFER_CHARACTERISTICS_PQ and AVIF_TRANSFER_CHARACTERISTICS_SMPTE2084 for the transfer_characteristics value 16. I think we can make an exception for that constant because PQ is better known than SMPTE ST 2084.
y-guyon
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This order suggests that AVIF_COLOR_PRIMARIES_BT709 is the main name of the constant and AVIF_COLOR_PRIMARIES_SRGB is an alias. The association of color_primaries value 1 with BT.709 is well known.