Gainmap computation: fix handling of extreme values. #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-guyon
approved these changes
Dec 11, 2023
src/gainmap.c
Outdated
Comment on lines
344
to
348
| const float bucketMin = min; | ||
| // Use a bucket range of constant size 12 so that each bucket has a fixed size. | ||
| // 12 is an arbitrary empirical value, equivalent to a [-6, +6] range, where | ||
| // +6 is roughly equivalent to bringing SDR white to max PQ white (log2(10000/203) ~= 5.62). | ||
| const float bucketMax = min + 12; |
There was a problem hiding this comment.
Why not use [0:12] rather than [min:min+12]? It seems weird to fix the relative maximum but not the absolute minimum.
Also [-6:+6] is mentioned but the used range is [min:min+12]. Is min expected to be around -6?
There was a problem hiding this comment.
It was intentional but the intention was not very clear :) I reworked the code to make it clearer hopefully that the idea is to have buckets of fixed size.
Gain map values outside of [-6, +6] were being clamped.
y-guyon
approved these changes
Dec 12, 2023
The idea is to have buckets of fixed size. Add test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gain map values outside of [-6, +6] were being clamped.