Fix failing assert if there are several 'dimg' boxes for the same item. #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not allowed by the HEIF specification. Also reject images where the base image and the gain map are the same image. This is not expecitly forbidden by existing draft specs but makes little sense and is not supported by the current code. Fixes b/314637273
y-guyon
approved these changes
Dec 4, 2023
Comment on lines
+4457
to
+4459
| // Even with numDimgItemIDs == 2, one of the ids could be 0 if there are duplicate entries in the 'dimg' box. | ||
| if (numDimgItemIDs != 2 || dimgItemIDs[0] == 0 || dimgItemIDs[1] == 0) { | ||
| avifDiagnosticsPrintf(data->diag, "box[dimg] for 'tmap' item %d must have exactly 2 entries with distinct ids", item->id); |
There was a problem hiding this comment.
Would the dimgItemIDs[otherItem->dimgIdx] == 0 assertion fail if that were to happen? Should it be removed or replaced by a proper error instead?
There was a problem hiding this comment.
No, the assert can fail only if there are mutiple dimg boxes for the same item, which we now reject earlier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not allowed by the HEIF specification.
Also reject images where the base image and the gain map are the same image. This is not expecitly forbidden by existing draft specs but makes little sense and is not supported by the current code.
Fixes b/314637273