Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(svt): Don't clamp enc_mode to [0,8] #1824

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

fdintino
Copy link
Contributor

SVT-AV1 added encoder modes 9-12 in v0.9. Because speed is still clamped to max 8 it's not possible to use any of these faster presets.

This still would prevent users from selecting M11 or M12, but addressing that would require broader changes.

@vrabaud
Copy link
Collaborator

vrabaud commented Nov 30, 2023

I guess we should keep the old behavior for older versions:

#if(SVT_AV1_CHECK_VERSION(0,9,0)
            svt_config->enc_mode = (int8_t)encoder->speed;
#else
            int speed = AVIF_CLAMP(encoder->speed, 0, 8);
            svt_config->enc_mode = (int8_t)speed;
#endif

SVT-AV1 added encoder modes 9-12 in v0.9. Because speed is still clamped
to max 8 it's not possible to use a faster preset.
@fdintino fdintino force-pushed the fix/svt-enc-mode-clamp branch from d3c6527 to 43463e9 Compare November 30, 2023 14:37
@vrabaud vrabaud merged commit c44a43b into AOMediaCodec:main Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants