Add missing result check and fix build warning. (#1871)

AOMediaCodec · Dec 12, 2023 · 59ce269 · 59ce269
1 parent a1eb55d
commit 59ce269
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
@@ -115,7 +115,7 @@ if(AVIF_ENABLE_GTEST)
     add_avif_gtest_with_data(avifdecodetest)
 
     if(AVIF_ENABLE_EXPERIMENTAL_GAIN_MAP)
-        add_avif_gtest_with_data(avifgainmaptest avifincrtest_helpers)
+        add_avif_internal_gtest_with_data(avifgainmaptest avifincrtest_helpers)
 
         if(AVIF_ENABLE_EXPERIMENTAL_JPEG_GAIN_MAP_CONVERSION)
             add_avif_gtest_with_data(avifjpeggainmaptest)

diff --git a/tests/gtest/avifgainmaptest.cc b/tests/gtest/avifgainmaptest.cc
@@ -1358,7 +1358,9 @@ TEST(FindMinMaxWithoutOutliers, AllSame) {
     std::vector<float> values(kNumValues, v);
 
     float min, max;
-    avifFindMinMaxWithoutOutliers(values.data(), kNumValues, &min, &max);
+    ASSERT_EQ(
+        avifFindMinMaxWithoutOutliers(values.data(), kNumValues, &min, &max),
+        AVIF_RESULT_OK);
     EXPECT_EQ(min, v);
     EXPECT_EQ(max, v);
   }
@@ -1388,7 +1390,9 @@ TEST(FindMinMaxWithoutOutliers, Test) {
     }
 
     float min, max;
-    avifFindMinMaxWithoutOutliers(values.data(), kNumValues, &min, &max);
+    ASSERT_EQ(
+        avifFindMinMaxWithoutOutliers(values.data(), kNumValues, &min, &max),
+        AVIF_RESULT_OK);
     const float kEpsilon = 0.001f;
     EXPECT_NEAR(min, value_shift + 1.97f, kEpsilon);
     const float bucketSize = 0.01f;  // Size of one bucket.