Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[foxy-devel]use rosbag2_storage::StorageOptions instead of rosbag2_cpp::StorageOptions #389

Closed
wants to merge 1 commit into from

Conversation

heweweh
Copy link

@heweweh heweweh commented Mar 22, 2023

rosbag2_cpp::StorageOptions is deprecated and it triggers a hard break of building error now.

autowareauto/src/external/grid_map/grid_map_ros/src/GridMapRosConverter.cpp:670:16: error: ‘StorageOptions’ is not a member of ‘rosbag2_cpp’
  670 |   rosbag2_cpp::StorageOptions storage_options;
      |                ^~~~~~~~~~~~~~
...
autowareauto/src/external/grid_map/grid_map_ros/src/GridMapRosConverter.cpp:706:16: error: ‘StorageOptions’ is not a member of ‘rosbag2_cpp’
  706 |   rosbag2_cpp::StorageOptions storage_options;
      |                ^~~~~~~~~~~~~~

I have changed them to deserved rosbag2_storage::StorageOptions.

@heweweh
Copy link
Author

heweweh commented Mar 23, 2023

@maximilianwulf would you mind to review this PR?

@heweweh heweweh changed the title use rosbag2_storage::StorageOptions instead of rosbag2_cpp::StorageOptions [foxy-devel]use rosbag2_storage::StorageOptions instead of rosbag2_cpp::StorageOptions Mar 23, 2023
@Ryanf55 Ryanf55 added the ros2 Affects ROS 2 label Jan 31, 2024
@Ryanf55 Ryanf55 added this to the 2.2.0 milestone Feb 3, 2024
@Ryanf55
Copy link
Collaborator

Ryanf55 commented Feb 12, 2024

@Ryanf55 Ryanf55 closed this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid ros2 Affects ROS 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants