-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Update ITK tag. #1847
ENH: Update ITK tag. #1847
Conversation
I had hoped to build against the 5.4.2 release but it seems like that doesn't include your fix. What tools are affected by this patch? |
@thewtex mentions backporting to ITK 5.4.3. The bug affects b-spline fitting but only for closed parametric dimensions. So almost none of the tools in ANTsX would be effected except for FitBSplineToPoints.cxx and fitBsplineObjectToScatteredData in ANTsR (and its analog in ANTsPy). If you want to hold off, I'm fine with that. |
Thanks for the info. I think it's fine to update, we can update again when 5.4.3 comes out. It mostly helps the conda folks to have tagged versions of ants that rely on tagged versions of ITK. |
Okay, thanks. Let me finish compiling and testing locally and then I'll merge. |
So follow-up question @cookpa---can we update the ANTs git tag in ANTsPy and ANTsR or should we hold off? |
In ANTsPy we will need to update and verify the label stats code I did what I could in #1737 to make this change less painful. The one thing I couldn't get from the new filter was the weighted centroid |
ANTsR will need to update labelGeometryMeasures.R |
Okay, I'll take a look. Thanks. |
Thanks @ntustison. Some more details here |
Hey @cookpa , it's been about a year since we've updated ITK. I recently fixed an ITK bug that affects some tools in the ANTsX ecosystem and would like to reflect the ITK changes here. Any potential issues that you're aware of?