Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a missing semicolon #986

Merged
merged 1 commit into from
Jun 8, 2020
Merged

Fix a missing semicolon #986

merged 1 commit into from
Jun 8, 2020

Conversation

WeiqunZhang
Copy link
Member

The (DPC++ only) bug was in

if (....) return
ParallelFor(...);
ParallelFor(...);

A semicolon was missing and the code became

if(...) {
    return ParallelFor(...);
}
ParallelFor(...);

Maybe we should always use {} with if no matter how short the block is.

@WeiqunZhang WeiqunZhang requested review from atmyers and asalmgren June 8, 2020 04:17
@atmyers
Copy link
Member

atmyers commented Jun 8, 2020

:(

@atmyers atmyers merged commit 86a361c into AMReX-Codes:development Jun 8, 2020
@WeiqunZhang WeiqunZhang deleted the dpcpp/missing_semicolon branch June 10, 2020 16:05
@sayerhs sayerhs mentioned this pull request Nov 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atmyers atmyers atmyers approved these changes

@asalmgren asalmgren Awaiting requested review from asalmgren

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WeiqunZhang @atmyers