Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify warning messages about number of GPUs #4315

Merged
merged 1 commit into from
Jan 28, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Src/Base/AMReX_GpuDevice.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ Device::Initialize ()
}
else {
if (amrex::Verbose() && ParallelDescriptor::IOProcessor()) {
amrex::Warning("Multiple GPUs are visible to each MPI rank, This may lead to incorrect or suboptimal rank-to-GPU mapping.");
amrex::Warning("Multiple GPUs are visible to each MPI rank. This is usually not an issue. But this may lead to incorrect or suboptimal rank-to-GPU mapping.");
}
if (ParallelDescriptor::NProcsPerNode() == gpu_device_count) {
device_id = ParallelDescriptor::MyRankInNode();
Expand Down Expand Up @@ -322,7 +322,8 @@ Device::Initialize ()
<< ((num_devices_used == 1) ? " device.\n"
: " devices.\n");
if (num_devices_used < ParallelDescriptor::NProcs() && ParallelDescriptor::IOProcessor()) {
amrex::Warning("There are more MPI processes than the number of GPUs.");
amrex::Warning("There are more MPI processes than the number of unique GPU devices. This is not necessarily a problem.\n"
"For example this could happen when a device such as MI300A is partitioned into multiple subdevices.");
}
}

Expand Down
Loading