std::clamp -> amrex::Clamp #4292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
std::clamp is a constexpr function, and it is supposed to work in device code. However, std::clamp in gcc 14 seems to be incompatible with clang. This is causing clang based HIP compiler to fail on systems using gcc 14 libstd as reported by multiple users. Here we work around the issue by using amrex::Clamp instead.
atmyers
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::clamp is a constexpr function, and it is supposed to work in device code. However, std::clamp in gcc 14 seems to be incompatible with clang. This is causing clang based HIP compiler to fail on systems using gcc 14 libstd as reported by multiple users. Here we work around the issue by using amrex::Clamp instead.