-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add special named flag for invalid particles #3688
Merged
atmyers
merged 6 commits into
AMReX-Codes:development
from
atmyers:invalid_particle_flag
Jan 12, 2024
Merged
Add special named flag for invalid particles #3688
atmyers
merged 6 commits into
AMReX-Codes:development
from
atmyers:invalid_particle_flag
Jan 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atmyers
commented
Jan 5, 2024
atmyers
commented
Jan 5, 2024
ax3l
reviewed
Jan 5, 2024
ax3l
reviewed
Jan 5, 2024
ax3l
reviewed
Jan 9, 2024
AlexanderSinn
approved these changes
Jan 9, 2024
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
Note that doing
is still okay, because if the original
will restore the original |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets you do
p.m_idcpu = LongParticleIDs::InvalidParticleID;
instead of
amrex::ParticleIDWrapper{p.m_idcpu} = -1;
The proposed changes: