Fix bug in EBNodeFDLap #3271
Merged
Fix bug in EBNodeFDLap #3271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this linear solver for WarpX, we missed a corner case where the edge with a length of exactly 1 has one end exactly on the EB surface. It is fixed by using the implicit function to detect covered nodes.
54047e7 to
01521b9
Compare
atmyers
approved these changes
Apr 25, 2023
ax3l
reviewed
May 1, 2023
Comment on lines
+348
to
+349
| tmp += -x(i,j,k) / hm * (r - Real(0.5) * hm * dr); | ||
| tmp0 += Real(-1.0) / hm * (r - Real(0.5) * hm * dr); |
There was a problem hiding this comment.
This is a bug fix.
- 2x
hp->hm: related to cut cell ratio
WeiqunZhang
commented
May 1, 2023
| tmp += (x(i-1,j,k) - x(i,j,k)) * (r - Real(0.5) * dr); | ||
| } else { | ||
| hm = Real(1.0) - Real(2.) * ecx(i-1,j,k); | ||
| tmp += (xeb(i-1,j,k) - x(i,j,k)) / hm * (r - Real(0.5) * hp * dr); | ||
| tmp += (xeb(i-1,j,k) - x(i,j,k)) / hm * (r - Real(0.5) * hm * dr); |
There was a problem hiding this comment.
@RemiLehe This was also fixed by hp -> hm.
guj
pushed a commit
to guj/amrex
that referenced
this pull request
Jul 13, 2023
In this linear solver for WarpX, we missed a corner case where the edge with a length of exactly 1 has one end exactly on the EB surface. It is fixed by using the implicit function to detect covered nodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this linear solver for WarpX, we missed a corner case where the edge with a length of exactly 1 has one end exactly on the EB surface. It is fixed by using the implicit function to detect covered nodes.