CPU version of TagBox::buffer #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37ac8bf to
380e028
Compare
Add a CPU version of TagBox::buffer. @MSABuschman reported in AMReX-Codes#1951 that TagBox::buffer has been very slow since commit AMReX-Codes#1258 if the error buffer size is large. The function was rewritten in AMReX-Codes#1258 to do the work on GPU. In this PR, the old version is reintroduced for CPU. Note that the current implementation is expected to have poor performance on GPU if it has a very large error buffer. It's still not clear how we should implement this function for GPU if a large error buffer is used.
380e028 to
1c86ec4
Compare
atmyers
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a CPU version of TagBox::buffer. @MSABuschman reported in #1951 that
TagBox::buffer has been very slow since commit #1258 if the error buffer
size is large. The function was rewritten in #1258 to do the work on GPU.
In this PR, the old version is reintroduced for CPU.
Note that the current implementation is expected to have poor performance on
GPU if it has a very large error buffer. It's still not clear how we should
implement this function for GPU if a large error buffer is used.
Checklist
The proposed changes: