Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix precision issue in ParmParse::add #1783

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Fix precision issue in ParmParse::add #1783

merged 1 commit into from
Feb 9, 2021

Conversation

WeiqunZhang
Copy link
Member

Summary

When adding values to ParmParse, we need to call std::setprecision so as
not to lose precision.

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • are described in the proposed changes to the AMReX documentation, if appropriate

@WeiqunZhang
Fix precision issue in ParmParse::add
f5aa44e 
When adding values to ParmParse, we need to call `std::setprecision` so as
not to lose precision.
@WeiqunZhang WeiqunZhang requested review from atmyers and kngott February 9, 2021 01:39
@WeiqunZhang
Copy link
Member Author

Thank @dpgrote for reporting this!

@atmyers atmyers merged commit 6219fa1 into AMReX-Codes:development Feb 9, 2021
@WeiqunZhang WeiqunZhang deleted the parmparse_precision branch February 9, 2021 02:42
@EZoni EZoni mentioned this pull request Feb 9, 2021
Merged
@ax3l ax3l added the bug label Feb 9, 2021
sayerhs pushed a commit to Exawind/amr-wind that referenced this pull request Feb 11, 2021
@marchdf
Update MMS golds (#339)
7928af7 
AMReX-Codes/amrex#1783
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atmyers atmyers atmyers approved these changes

@kngott kngott Awaiting requested review from kngott

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WeiqunZhang @atmyers @ax3l