Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for particle containers constructed with the same AmrCore... #1532

Merged
merged 3 commits into from
Nov 10, 2020

Conversation

atmyers
Copy link
Member

@atmyers atmyers commented Nov 9, 2020

... object to use different dual-grid options.

This is needed in Hipace++, since plasma and beam particles will have different BoxArrays and Geometry objects.

@MaxThevenet reports that this fixes the issues he was seeing.

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • are described in the proposed changes to the AMReX documentation, if appropriate

@atmyers atmyers changed the title Allow for particle containers constructed with the same AmrCore objec… Allow for particle containers constructed with the same AmrCore... Nov 9, 2020
@atmyers atmyers marked this pull request as ready for review November 10, 2020 15:53
@atmyers atmyers requested a review from WeiqunZhang November 10, 2020 15:53
@atmyers atmyers merged commit d9f60b4 into AMReX-Codes:development Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants