Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Spelling: Env AMREX_CUDA_ARCH #1522

Merged
merged 1 commit into from
Nov 7, 2020
Merged

Change Spelling: Env AMREX_CUDA_ARCH #1522

merged 1 commit into from
Nov 7, 2020

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Nov 7, 2020 •
edited
Loading

Summary

Make the environment variable that sets a default CUDA architecture all-caps, as this is way more common in Unix.

Typical Values: 7.0 or Volta (i.e. for V100)

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • are described in the proposed changes to the AMReX documentation, if appropriate

@ax3l
Change Spelling: Env AMREX_CUDA_ARCH
7e2ceee 
Make the environment variable all-caps, as this is way more common in
Unix.
@ax3l ax3l added the install label Nov 7, 2020
@ax3l ax3l mentioned this pull request Nov 7, 2020
Merged
5 tasks
@ax3l ax3l mentioned this pull request Nov 7, 2020
Merged
@WeiqunZhang WeiqunZhang merged commit ec4424e into AMReX-Codes:development Nov 7, 2020
@ax3l ax3l deleted the topic-cudaEnvVarCaps branch November 8, 2020 20:22
@sayerhs sayerhs mentioned this pull request Nov 14, 2020
Closed
@ax3l ax3l mentioned this pull request May 18, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeiqunZhang WeiqunZhang WeiqunZhang approved these changes

@maximumcats maximumcats maximumcats approved these changes

@mic84 mic84 Awaiting requested review from mic84

Assignees

@mic84 mic84

Labels
install
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ax3l @WeiqunZhang @maximumcats @mic84