Fix potential out of bounds access in #1441 #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drummerdoc
approved these changes
Oct 16, 2020
| @@ -442,7 +442,7 @@ std::ostream& operator << (std::ostream& os, const ErrorList& elst); | |||
| { | |||
| AMREX_ASSERT(value.size() > 0); | |||
| m_value.resize(info.m_max_level); | |||
| for (int i = 0; i < value.size(); ++i) { | |||
| for (int i = 0; i < m_value.size() && i < value.size(); ++i) { | |||
There was a problem hiding this comment.
An overabundance of caution? Can't be wrong, but curious what brought that on... -M
There was a problem hiding this comment.
In Castro I accidentally gave it a vector with max_level+1 values :-)
There was a problem hiding this comment.
Having the vector of values also gives errors if I'd set max_level=-1, meaning I don't want to use that constraint in that particular run. But max_level=0 works for that purpose as well, since it's strictly less than
There was a problem hiding this comment.
Yeah that's right, usually with AMR/tagging related things you just set it to max_level = 0 when you want to turn it off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The user may have given us a vector that has too many values, so we just ignore the remainder.
Additional background
Checklist
The proposed changes: