Fix when small_volfrac is used -- we need to adjust the data in cut c… #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ell neighbors as well as regular neighbors
WeiqunZhang
approved these changes
Oct 14, 2020
WeiqunZhang
added a commit
to WeiqunZhang/amrex
that referenced
this pull request
Oct 29, 2020
A GPU race condition was introduced in AMReX-Codes#1451 trying to fix faces and cells next to covered cells that were converted from small cut cells. It is fixed by launching a separate kernel for each direction.
5 tasks
asalmgren
pushed a commit
that referenced
this pull request
Oct 29, 2020
A GPU race condition was introduced in #1451 trying to fix faces and cells next to covered cells that were converted from small cut cells. It is fixed by launching a separate kernel for each direction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix when small_volfrac is used -- we need to adjust the data in cut cell neighbors as well as regular neighbors
This addresses issue #1450
Summary
Additional background
Checklist
The proposed changes: