Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix function type for HIP #1393

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Fix function type for HIP #1393

merged 1 commit into from
Sep 22, 2020

Conversation

WeiqunZhang
Copy link
Member

@WeiqunZhang WeiqunZhang commented Sep 22, 2020 •
edited
Loading

Summary

Currently in HIP we do not have a way to do SFINAE based on whether the
function is callable on host or not. So we have to replace the device
lambda with host and device lambda for HIP to compile.

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • are described in the proposed changes to the AMReX documentation, if appropriate

@WeiqunZhang
Fix function type for HIP
90dd997 
Currently in HIP we do not have a way to do SNFINAE based on whether the
function is callable on host or not.  So we have to replace the device
lambda with host and device lambda.
@WeiqunZhang WeiqunZhang requested a review from mic84 September 22, 2020 20:18
@mic84 mic84 merged commit 784f231 into AMReX-Codes:development Sep 22, 2020
@WeiqunZhang WeiqunZhang deleted the hip/host_device branch September 22, 2020 20:34
kweide pushed a commit to ECP-Astro/amrex that referenced this pull request Sep 28, 2020
@WeiqunZhang @kweide
Fix function type for HIP (AMReX-Codes#1393)
fa08205 
Currently in HIP we do not have a way to do SNFINAE based on whether the
function is callable on host or not.  So we have to replace the device
lambda with host and device lambda.
kweide added a commit to ECP-Astro/amrex that referenced this pull request Sep 28, 2020
@kweide
Revert "Fix function type for HIP (AMReX-Codes#1393)"
f04d6ad 
This reverts commit fa08205.
dwillcox pushed a commit to dwillcox/amrex that referenced this pull request Oct 3, 2020
@WeiqunZhang @dwillcox
Fix function type for HIP (AMReX-Codes#1393)
38972b3 
Currently in HIP we do not have a way to do SNFINAE based on whether the
function is callable on host or not.  So we have to replace the device
lambda with host and device lambda.
@sayerhs sayerhs mentioned this pull request Nov 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mic84 mic84 mic84 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WeiqunZhang @mic84