Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roundoff domain bugfixes #1353

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Conversation

atmyers
Copy link
Member

@atmyers atmyers commented Sep 8, 2020

This fixes two bugs. We now:

  1. Always recompute offset, dx, and inv_dx whenever the roundoff domain is computed, to make sure it is up-to-date.
  2. Recompute the roundoff domain when Domain() is changed, as well as ProbDomain().

MFIX triggered these because it sometimes grows the ProbDomain(), and only later changes the Domain().

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • are described in the proposed changes to the AMReX documentation, if appropriate

… either the ProbDomain or Domain is changed.
@asalmgren asalmgren merged commit a2aebd2 into AMReX-Codes:development Sep 8, 2020
kweide pushed a commit to ECP-Astro/amrex that referenced this pull request Sep 28, 2020
kweide added a commit to ECP-Astro/amrex that referenced this pull request Sep 28, 2020
…ain when either the ProbDomain or Domain is changed. (AMReX-Codes#1353)"

This reverts commit 7f81ed1.
dwillcox pushed a commit to dwillcox/amrex that referenced this pull request Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants