Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: add HIP support #1316

Merged
merged 77 commits into from
Oct 13, 2020
Merged

CMake: add HIP support #1316

merged 77 commits into from
Oct 13, 2020

Conversation

mic84
Copy link
Contributor

@mic84 mic84 commented Aug 26, 2020

Summary

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • are described in the proposed changes to the AMReX documentation, if appropriate

@mic84 mic84 requested review from ax3l and WeiqunZhang August 26, 2020 23:54
mic84 and others added 2 commits September 3, 2020 10:35
@mic84 @ax3l
Update Tools/CMake/AMReXParallelBackends.cmake
bb1a732 
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
@ax3l
CI: Add HIP-Clang
99fcf6f
ax3l
ax3l reviewed Sep 3, 2020
View reviewed changes
@mic84 @sayerhs
Update Docs/sphinx_documentation/source/GPU.rst
f2f52c1 
Co-authored-by: Shreyas Ananthan <shreyas@umd.edu>
@mic84 mic84 marked this pull request as ready for review September 30, 2020 18:10
@mic84 mic84 requested review from WeiqunZhang and ax3l September 30, 2020 18:11
@mic84 mic84 changed the title [WIP] CMake: add HIP support CMake: add HIP support Oct 1, 2020
@ax3l ax3l mentioned this pull request Oct 5, 2020
Merged
@mic84 mic84 merged commit 6649d22 into AMReX-Codes:development Oct 13, 2020
@mic84 mic84 deleted the mr/cmake-hip-support branch October 13, 2020 18:52
@sayerhs sayerhs mentioned this pull request Nov 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayerhs sayerhs sayerhs left review comments

@WeiqunZhang WeiqunZhang WeiqunZhang approved these changes

@ax3l ax3l Awaiting requested review from ax3l

Assignees
No one assigned
Labels
GPU install test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mic84 @sayerhs @ax3l @WeiqunZhang