Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for Tulip #1278

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Updates for Tulip #1278

merged 1 commit into from
Aug 19, 2020

Conversation

WeiqunZhang
Copy link
Member

Summary

  • Force DEBUG=FALSE for HIP to avoid a compiler bug.

  • Modify makefile so that the dependency files are not dumped in the current
    directory.

  • Add support for MPI.

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • are described in the proposed changes to the AMReX documentation, if appropriate

* Force DEBUG=FALSE for HIP to avoid a compiler bug.

* Modify makefile so that the dependency files are not dumped in the current
  directory.

* Add support for MPI.
@WeiqunZhang WeiqunZhang requested review from kngott and atmyers August 19, 2020 00:06
@WeiqunZhang WeiqunZhang merged commit cb2cdfa into AMReX-Codes:development Aug 19, 2020
@WeiqunZhang WeiqunZhang deleted the tulip branch August 19, 2020 00:21
dwillcox pushed a commit to dwillcox/amrex that referenced this pull request Oct 3, 2020
## Summary

* Force DEBUG=FALSE for HIP to avoid a compiler bug.

* Modify makefile so that the dependency files are not dumped in the current
  directory.

* Add support for MPI.

## Additional background

## Checklist

The proposed changes:
- [ ] fix a bug or incorrect behavior in AMReX
- [ ] add new capabilities to AMReX
- [ ] changes answers in the test suite to more than roundoff level
- [ ] are likely to significantly affect the results of downstream AMReX users
- [ ] are described in the proposed changes to the AMReX documentation, if appropriate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants