Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace amrcore tutorial #1253

Merged

Conversation

asalmgren
Copy link
Member

@asalmgren asalmgren commented Aug 11, 2020

Summary

This replaces the existing tutorial with the more general, all C++ one developed for ATPESC 2020. This version works for CPU and GPU (compile-time option), in 2D and 3D (compile-time option), with and without subcycling (run-time option).
A .md file is also included in the directory which walks a new user through how to run this code and what to experiment with to understand AMR.

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • are described in the proposed changes to the AMReX documentation, if appropriate

ATPESC 2020.  The new code is written entirely in C++, supports subcycling
and non-subcycling options (controlled by a flag in the inputs file),
and works on CPU or GPU.
@asalmgren asalmgren requested a review from WeiqunZhang August 11, 2020 01:22
@WeiqunZhang WeiqunZhang merged commit ac2128c into AMReX-Codes:development Aug 15, 2020
@asalmgren asalmgren deleted the replace_amrcore_tutorial branch August 17, 2020 20:46
dwillcox pushed a commit to dwillcox/amrex that referenced this pull request Oct 3, 2020
## Summary

This replaces the existing tutorial with the more general, all C++ one developed for ATPESC 2020.  This version works for CPU and GPU (compile-time option), in 2D and 3D (compile-time option), with and without subcycling (run-time option).
A .md file is also included in the directory which walks a new user through how to run this code and what to experiment with to understand AMR.

## Checklist

The proposed changes:
- [ ] fix a bug or incorrect behavior in AMReX
- [ ] add new capabilities to AMReX
- [ ] changes answers in the test suite to more than roundoff level
- [ ] are likely to significantly affect the results of downstream AMReX users
- [x] are described in the proposed changes to the AMReX documentation, if appropriate


Co-authored-by: Weiqun Zhang <weiqunzhang@lbl.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants