Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings for USE_SINGLE_PRECISION_PARTICLES=TRUE, PRECISION=DOUBLE #1240

Conversation

atmyers
Copy link
Member

@atmyers atmyers commented Aug 7, 2020

Note that one of these is an actual bug that went undetected for years. That's why you pay attention to warnings I guess...

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • are described in the proposed changes to the AMReX documentation, if appropriate

@atmyers atmyers requested a review from WeiqunZhang August 7, 2020 23:17
@WeiqunZhang WeiqunZhang merged commit 09db04b into AMReX-Codes:development Aug 7, 2020
dwillcox pushed a commit to dwillcox/amrex that referenced this pull request Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants