Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rvalues for functions that take callables #1231

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Use rvalues for functions that take callables #1231

merged 1 commit into from
Aug 5, 2020

Conversation

atmyers
Copy link
Member

@atmyers atmyers commented Aug 5, 2020

There is no downside to doing it this way, and it may have better performance for some compilers / situations, although tests on Summit did not see a noticeable change.

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • are described in the proposed changes to the AMReX documentation, if appropriate

@atmyers atmyers requested a review from WeiqunZhang August 5, 2020 19:53
@atmyers atmyers merged commit 888e804 into AMReX-Codes:development Aug 5, 2020
dwillcox pushed a commit to dwillcox/amrex that referenced this pull request Oct 3, 2020
@atmyers @dwillcox
use rvalues for functions that take callables (AMReX-Codes#1231)
2810c3b
@sayerhs sayerhs mentioned this pull request Nov 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeiqunZhang WeiqunZhang WeiqunZhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atmyers @WeiqunZhang