Optimization of the construction of SFC #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4908ede to
622f63b
Compare
The Morton numbers are explicitly constructed and stored in SFCTokens. This speeds up the sorting in making space filling curve significantly.
|
I wrote a test code to compare the old and new approaches by sorting a vector of 1e8 tokens. The results agree with each other. https://github.com/WeiqunZhang/random/tree/main/sfc |
atmyers
approved these changes
Aug 4, 2020
dwillcox
pushed a commit
to dwillcox/amrex
that referenced
this pull request
Oct 3, 2020
## Summary The Morton numbers are explicitly computed and stored in SFCTokens. This speeds up the sorting in making space filling curve significantly. ## Checklist The proposed changes: - [ ] fix a bug or incorrect behavior in AMReX - [ ] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] are described in the proposed changes to the AMReX documentation, if appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Morton numbers are explicitly computed and stored in SFCTokens. This
speeds up the sorting in making space filling curve significantly.
Checklist
The proposed changes: