The average_down_faces calls between AMR levels in the linear solvers need to see periodicity #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that sees the periodicity. This requires adding that functionality to EB_average_down_faces (it has already been added to non-EB average_down_faces.)
WeiqunZhang
reviewed
Aug 2, 2020
Src/EB/AMReX_EBMultiFabUtil.cpp
Outdated
| int ncomp = crse[0]->nComp(); | ||
| if (!(*fine[0]).hasEBFabFactory()) | ||
| { | ||
| amrex::average_down_faces(fine, crse, ratio, ngcrse); |
There was a problem hiding this comment.
It seems that we should call the version with Geometry.
WeiqunZhang
reviewed
Aug 2, 2020
Src/EB/AMReX_EBMultiFabUtil.cpp
Outdated
| } | ||
| } | ||
| } | ||
| // TODO: NEED TO ENFORCE PERIODICITY IN THIS CASE |
There was a problem hiding this comment.
I think we could remove this entire block of if (isMFIterSafe(*fine[0], *crse[0])). If we need to enforce periodicity, we have to do the thing in the else block below.
WeiqunZhang
approved these changes
Aug 2, 2020
dwillcox
pushed a commit
to dwillcox/amrex
that referenced
this pull request
Oct 3, 2020
… need to see periodicity (AMReX-Codes#1221) The average_down_faces calls between AMR levels need to use the interfaces that sees the periodicity. This requires adding that functionality to EB_average_down_faces (it has already been added to non-EB average_down_faces.) ## Summary Recently we added the functionality for an average_down_faces call to average fine data from one side to average not only onto the face under it but also onto the face on the other side of the domain if periodic in that direction. This PR 1) extends that functionality to the EB_average_down_faces call and 2) uses this new functionality when averaging down face-based coefficients between AMR levels in the cell-centered linear solvers. ## Checklist The proposed changes: - [X] fix a bug or incorrect behavior in AMReX - [X] add new capabilities to AMReX - [X] changes answers in the test suite to more than roundoff level - [X] are likely to significantly affect the results of downstream AMReX users - [ ] are described in the proposed changes to the AMReX documentation, if appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The average_down_faces calls between AMR levels need to use the interfaces that sees the periodicity. This requires adding that functionality to EB_average_down_faces (it has already been added to non-EB average_down_faces.)
Summary
Recently we added the functionality for an average_down_faces call to average fine data from one side to average not only onto the face under it but also onto the face on the other side of the domain if periodic in that direction. This PR 1) extends that functionality to the EB_average_down_faces call and 2) uses this new functionality when averaging down face-based coefficients between AMR levels in the cell-centered linear solvers.
NOTE: I have left a "TODO" in amrex/Src/EB/AMReX_EBMultiFabUtil.cpp -- I wasn't sure how to best implement the functionality in that case
Additional background
Checklist
The proposed changes: