Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Average down faces #1216

Merged
merged 1 commit into from
Jul 31, 2020
Merged

Conversation

WeiqunZhang
Copy link
Member

New average_down_faces functions that take coarse Geometry and average down periodically.

Summary

Add new versions of average_down faces factions that take coarse Geometry as an argument. The average-down takes periodicity into account.

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • are described in the proposed changes to the AMReX documentation, if appropriate

New average_down_faces functions that take coarse Geometry and average down periodically.
@WeiqunZhang WeiqunZhang requested review from atmyers and asalmgren July 31, 2020 03:14
@asalmgren
Copy link
Member

This test fixes the lack of conservation of the no-subcycling multi-level advected scalar problem -- in a 4-level scalar advection problem we now have conservation with this feature.

@asalmgren asalmgren merged commit 2dad6e2 into AMReX-Codes:development Jul 31, 2020
@WeiqunZhang WeiqunZhang deleted the average_down_faces branch August 5, 2020 17:18
dwillcox pushed a commit to dwillcox/amrex that referenced this pull request Oct 3, 2020
New average_down_faces functions that take coarse Geometry and average down periodically.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants