fix more warnings and add CI for building 3d with configure #1184
Conversation
f32cd2f to
fa70006
Compare
fa70006 to
8dd3bf4
Compare
| @@ -179,5 +179,19 @@ jobs: | |||
| - name: Build & Install | |||
| run: | | |||
| ./configure --dim 2 | |||
| make -j2 | |||
| make -j2 WARN_ALL=TRUE | |||
There was a problem hiding this comment.
do you also want to add this to the 1D case above? :)
There was a problem hiding this comment.
Another idea: we can add -Werror in CI through XTRA flags to check PRs do not introduce warnings for selected compilers :)
There was a problem hiding this comment.
There are too many warnings in 1D we need to fix. :( We do not fully support 1D. So in many places we just have a function with empty body. As for -Werror, we still have some warnings. One we get rid of them, we can add that to a few CI tests.
Src/Base/AMReX.H
Outdated
| @@ -89,6 +89,10 @@ namespace amrex | |||
| void ExecOnFinalize (PTR_TO_VOID_FUNC); | |||
| void ExecOnInitialize (PTR_TO_VOID_FUNC); | |||
|
|
|||
| //! This shuts up the compiler about unused variables | |||
| template <class... Ts> AMREX_GPU_HOST_DEVICE | |||
There was a problem hiding this comment.
I usually also put a force inline on that one and make it a constexpr.
Took inspiration from boost:
There was a problem hiding this comment.
Sounds good. Will update.
There was a problem hiding this comment.
Looks like we have take constexpr, because conexpr void is not supported in C++11.
There was a problem hiding this comment.
Ah right, in C++11 mode I used a const fallback originally: alpaka-group/alpaka#582
…des#1184) * fix more warnings and add CI for building 3d with configure * make ignore_unused constexpr and force inline * add AMREX_FALLTHROUGH * fix more warnings * enable xsdk in ci and test no_fortran * remove constexpr from ignore_unused for C++11 * use Clang for 2d ci * disable mpi for the 2d ci with clang
…1203) * Fix CellConservativeProtected bug from AMReX-Codes#1184 * Fix comment
No description provided.