Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WARN_ALL #1176

Merged
merged 2 commits into from
Jul 23, 2020
Merged

WARN_ALL #1176

merged 2 commits into from
Jul 23, 2020

Conversation

WeiqunZhang
Copy link
Member

Add WARN_ALL option to GNUMake system to turn on more compiler warnings for gcc and clang. The
default is FALSE. Fix a couple of bugs found by the warning and a number of warnings.

Add WARN_ALL option to GNUMake system to turn on more compiler warnings for gcc and clang.  The
default is FALSE.  Fix a couple of bugs found by the warning and a number of warnings.
@WeiqunZhang WeiqunZhang requested review from atmyers and ax3l July 23, 2020 05:41
@ax3l
Copy link
Member

ax3l commented Jul 23, 2020

Thank you, this is great!

Do you want to enable them in CI and potentially add a xtra-flags for -Werror to keep it so for PRs? :)

Don't forget to add WARN_ALL to the table in Docs/sphinx/source/BuildingAMReX.rst please.

@WeiqunZhang WeiqunZhang merged commit 411ea9b into AMReX-Codes:development Jul 23, 2020
@WeiqunZhang WeiqunZhang deleted the warn_all branch July 23, 2020 18:55
dwillcox pushed a commit to dwillcox/amrex that referenced this pull request Oct 3, 2020
* WARN_ALL

Add WARN_ALL option to GNUMake system to turn on more compiler warnings for gcc and clang.  The
default is FALSE.  Fix a couple of bugs found by the warning and a number of warnings.

* add WARN_ALL to documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants