Optimization of TagBoxArray::collate #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a new way to remove duplicated tags. Instead of removing duplicated from vector, we remove duplicates when tags are still stored in FabArray. Because they are in FabArray with a BoxArray that has no overlapped valid cells, we can use ParallelAdd to remove duplicates due to the overlap of valid cells with ghost cells. Assertion in AmrCore on blocking factor to make sure that there are no overlapped valid cells in TagBoxArray after coarsening. Use int version of Gatherv. The long version is not scalable. Broadcast pre-maxsized BoxList instead of tags. In most cases, this should reduce the amount of data to be broadcasted.
atmyers
approved these changes
Jul 20, 2020
WeiqunZhang
added a commit
to WeiqunZhang/amrex
that referenced
this pull request
Jul 26, 2020
In AMReX-Codes#1156, newly generated grids were not always properly nested because the tags in ghost cells were discarded. This is fixed and an assertion is added.
Merged
WeiqunZhang
added a commit
to WeiqunZhang/amrex
that referenced
this pull request
Jul 26, 2020
In AMReX-Codes#1156, newly generated grids were not always properly nested because the tags in ghost cells were discarded. This is fixed and an assertion is added.
WeiqunZhang
added a commit
that referenced
this pull request
Jul 26, 2020
dwillcox
pushed a commit
to dwillcox/amrex
that referenced
this pull request
Oct 3, 2020
Use a new way to remove duplicated tags. Instead of removing duplicated from vector, we remove duplicates when tags are still stored in FabArray. Because they are in FabArray with a BoxArray that has no overlapped valid cells, we can use ParallelAdd to remove duplicates due to the overlap of valid cells with ghost cells. Assertion in AmrCore on blocking factor to make sure that there are no overlapped valid cells in TagBoxArray after coarsening. Use int version of Gatherv. The long version is not scalable. Broadcast pre-maxsized BoxList instead of tags. In most cases, this should reduce the amount of data to be broadcasted.
dwillcox
pushed a commit
to dwillcox/amrex
that referenced
this pull request
Oct 3, 2020
In AMReX-Codes#1156, newly generated grids were not always properly nested because the tags in ghost cells were discarded. This is fixed and an assertion is added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a new way to remove duplicated tags. Instead of removing duplicated from vector, we remove
duplicates when tags are still stored in FabArray. Because they are in FabArray with a BoxArray
that has no overlapped valid cells, we can use ParallelAdd to remove duplicates due to the overlap
of valid cells with ghost cells.
Assertion in AmrCore on blocking factor to make sure that there are no overlapped valid cells in
TagBoxArray after coarsening.
Use int version of Gatherv. The long version is not scalable.
Broadcast pre-maxsized BoxList instead of tags. In most cases, this should reduce the amount of
data to be broadcasted.