Combine two functions for periodically shifting particles into one and re-use #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeiqunZhang
approved these changes
Jul 18, 2020
jmsexton03
requested changes
Jul 18, 2020
| @@ -222,8 +224,11 @@ void enforcePeriodic (P& p, | |||
| // clamp to avoid precision issues; | |||
| if (p.pos(idim) == phi[idim]) p.pos(idim) = plo[idim]; | |||
| if (p.pos(idim) > phi[idim]) p.pos(idim) = std::nextafter( (amrex::ParticleReal) phi[idim], (amrex::ParticleReal) plo[idim]); | |||
| shifted = true; | |||
| } | |||
| } | |||
There was a problem hiding this comment.
The assertion from PeriodicShift in terms of enforce_periodic should be:
AMREX_ASSERT( (p.pos(idim) >= plo[idim] ) and ( p.pos(idim) < phi[idim] ));
jmsexton03
approved these changes
Jul 18, 2020
dwillcox
pushed a commit
to dwillcox/amrex
that referenced
this pull request
Oct 3, 2020
…d re-use (AMReX-Codes#1152) * combine periodic shifts into one and re-use * fix assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of some code duplication.