Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1D CUDA compilation failure due to #1332 #1422

Closed
maximumcats opened this issue Sep 29, 2020 · 0 comments · Fixed by #1423
Closed

1D CUDA compilation failure due to #1332 #1422

maximumcats opened this issue Sep 29, 2020 · 0 comments · Fixed by #1423
Assignees
@WeiqunZhang
Labels
bug GPU

Comments

@maximumcats
Copy link
Member

#1332 has an issue compiling in 1D for CUDA (e.g. compiling CNS with DIM=1):

tmp_build_dir/s/1d.pgi.CUDA.EXE/AMReX_MultiFabUtil.cpp(221): error: duplicate parameter name

tmp_build_dir/s/1d.pgi.CUDA.EXE/AMReX_MultiFabUtil.cpp(221): error: no suitable constructor exists to convert from "amrex::Box (amrex::IntVect, amrex::IntVect)" to "amrex::Box"

I assume this is because the IntVect constructor is different in 1D but the 1D fusible kernel macro isn't quite doing the right thing in this case.
WeiqunZhang added a commit to WeiqunZhang/amrex that referenced this issue Sep 29, 2020
@WeiqunZhang
Fix 1D CUDA compilation failure due to AMReX-Codes#1332
cec79c0 
The most vexing parse in C++ strikes again.

This closes AMReX-Codes#1422.
@WeiqunZhang WeiqunZhang mentioned this issue Sep 29, 2020
Merged
5 tasks
WeiqunZhang added a commit that referenced this issue Sep 29, 2020
@WeiqunZhang
Fix 1D CUDA compilation failure due to #1332 (#1423)
f9a441a 
The most vexing parse in C++ strikes again.

This closes #1422.
dwillcox pushed a commit to dwillcox/amrex that referenced this issue Oct 3, 2020
@WeiqunZhang @dwillcox
Fix 1D CUDA compilation failure due to AMReX-Codes#1332 (AMReX-Codes#…
7d02e7f 
…1423)

The most vexing parse in C++ strikes again.

This closes AMReX-Codes#1422.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WeiqunZhang WeiqunZhang

Labels
bug GPU
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 1D CUDA compilation failure due to #1332 WeiqunZhang/amrex
2 participants
@WeiqunZhang @maximumcats