Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new AMReX tagging format #1243

Merged
merged 3 commits into from
Sep 29, 2020

Conversation

maximumcats
Copy link
Member

PR summary

The refinement scheme from AMReX-Codes/amrex#1166 is implemented. Rather than using the Fortran tagging namelist, applications may use the inputs file. The scheme looks like:

amr.refinement_indicators = dens temp

amr.refine.dens.max_level = 1
amr.refine.dens.value_greater = 2.0
amr.refine.dens.field_name = Density

amr.refine.temp.max_level = 2
amr.refine.temp.value_less = 1.0
amr.refine.temp.field_name = Temp

amr.refinement_indicators is a list of user-defined names for refinement schemes. For each defined name, amr.refine.<name> accepts predefined fields describing when to tag. In the current implementation, these are max_level (maximum level to refine to), start_time (when to start tagging), end_time (when to stop tagging), value_greater (value above which we refine), and value_less (value below which to refine), and field_name (name of the string defining the field in the code). If a refinement indicator is added, either value_greater or value_less must be provided. (In the future we will support other refinement schemes such as gradients.)

A wdmerger setup is converted to the new scheme as a test.

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@maximumcats maximumcats marked this pull request as ready for review September 29, 2020 04:11
@zingale
Copy link
Member

zingale commented Sep 29, 2020

@zingale zingale merged commit 2e5afbd into AMReX-Astro:development Sep 29, 2020
@maximumcats maximumcats deleted the new_tagging_format branch November 7, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants