Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark EventStore based I/O as deprecated #378

Merged
merged 3 commits into from
Mar 1, 2023

Conversation

tmadlener
Copy link
Collaborator

BEGINRELEASENOTES

  • Introduce deprecation warnings for the EventStore based I/O model as it will be removed in favor of the Frame based one

ENDRELEASENOTES

In order to pass CI deprecation warnings are temporarily accepted and this exception has to be taken back again when the EventStore code is removed.

@tmadlener
Copy link
Collaborator Author

The edm4hep workflow currently fails because it still uses the EventStore until key4hep/EDM4hep#184 is merged. I suggest we wait for that to go in first, and the merge this.

@hegner
Copy link
Collaborator

hegner commented Feb 21, 2023

@tmadlener - before merging we have to get the Gaudi part fixed as well.

@tmadlener
Copy link
Collaborator Author

In principle this can be merged even without those fixes since we are only introducing a few deprecation warnings and not yet removing anything. But since this is not extremely urgent we can also wait.

@hegner
Copy link
Collaborator

hegner commented Feb 22, 2023

@tmadlener - actually it is errors in the current setup. Otherwise the PR checks would succeed ;-)

@tmadlener
Copy link
Collaborator Author

The errors are deprecation warnings that are triggered in the EDM4hep build. They should be fixed by key4hep/EDM4hep#194 and key4hep/EDM4hep#182

@tmadlener
Copy link
Collaborator Author

All downstream (EDM4hep) fixes have been merged, so I think this could be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants