-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate an additional cmake lists file containing the generated source files #143
Conversation
3f02518
to
3219f55
Compare
Seems like ninja is not really satisfied with including a generated file here and enters an infinite loop. This doesn't happen with make. |
While googling: We should add the datamodel yaml file to the CMAKE_CONFIGURE_DEPENDS property (https://cmake.org/cmake/help/latest/prop_dir/CMAKE_CONFIGURE_DEPENDS.html) That cmake file should probably only written if its content changes to avoid triggering re-running? The header and source files should have the GENERATED property, having them in BYPRODUCTS was causing this to happen. |
Thanks for the I have added the templates to that list as well, as changes to the templates should also trigger a re-configuration. Now these changes should make it possible to have "dirty" directories into which the files are generated, as only those headers and source files that are actually generated by the podio code generator will be used to populate the corresponding cmake variables. This in turn makes the following possible:
|
c0d253e
to
3883dc0
Compare
3883dc0
to
2c3f101
Compare
2c3f101
to
0dccac5
Compare
dbfee7b
to
88b5fed
Compare
a80176c
to
c1ae07f
Compare
Rebased onto the laster master to resolve conflicts. |
@tmadlener - just to x-check. we are complete here and I can merge? |
Yes, for me this is complete. Maybe @andresailer wants to have another look. |
BEGINRELEASENOTES
podio_generated_files.cmake
file containing all generated source files as aheader
andsources
list and make the code generation macro include this file to get the headers and source files.ENDRELEASENOTES
This now makes it possible to seamlessly switch between branches of podio that generate different files :)
The contents of the generated file are the following
The
selection_xml
variable is not used at the moment, but since it is a generated file I put it there.