Discard non-new testcase events for multi-machine messages #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riesentoaster
pushed a commit
to riesentoaster/LibAFL
that referenced
this pull request
Oct 4, 2024
…us#2583) * discard non-new testcase events * clippy
domenukk
reviewed
Oct 7, 2024
|
|
||
| // If the message comes from another machine, do not | ||
| // consider other events than new testcase. | ||
| if !event.is_new_testcase() && (flags & LLMP_FLAG_FROM_MM == LLMP_FLAG_FROM_MM) { |
There was a problem hiding this comment.
Why? We can totally share metadata etc in the future
There was a problem hiding this comment.
Pretty sure this check belongs into handle_in_client, if it should exist et all(?)
There was a problem hiding this comment.
yes, we were trying to bugfix something quickly for an experiment, i was planning to clean-up this today.
I'll reopen a pr soon
There was a problem hiding this comment.
yes it was not a good idea in the first place, i'll just revert this one in the next patch
rmalmain
added a commit
that referenced
this pull request
Oct 7, 2024
* discard non-new testcase events * clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.