Basic implementation of World State. #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EanCuznaivy Hi, I have changed dev and merge my codes, can you merge some code from dev? |
|
@loning Let me see... |
# Conflicts: # AElf.Kernel/Chain.cs # AElf.Kernel/ChainManager.cs # AElf.Kernel/IAccountDataProvider.cs # AElf.Kernel/IDataProvider.cs # AElf.Kernel/ISmartContract.cs # AElf.Kernel/KernelAccount/SmartContractZero.cs # AElf.Kernel/Merkle/BinaryMerkleNode.cs
|
@loning Finally fixed the conflicts :) |
loning
requested changes
Feb 3, 2018
| { | ||
| public static class SerializationExtensions | ||
| { | ||
| public static byte[] Serialize(this object obj) |
There was a problem hiding this comment.
ISerializable a;
ojbect b= (object)a;
ISeralizable c = (ISeralizable) b;
var bytes= c.GetBytes();
var d=bytes.ToObject(); //Deseralize
AElf.Kernel/Hash.cs
Outdated
|
|
||
| namespace AElf.Kernel | ||
| { | ||
| [Serializable] | ||
| public class Hash<T> : IHash<T> | ||
| public class Hash<T> : IHash<T>, IComparer<Hash<T>> |
There was a problem hiding this comment.
interface IHash: IComparer<Hash>{
}
AElf.Kernel/Hash.cs
Outdated
| @@ -24,5 +23,15 @@ public Hash():this(new byte[32]) | |||
| public byte[] GetHashBytes() => Value; | |||
|
|
|||
| public bool Equals(IHash other) => Value == other.GetHashBytes(); | |||
There was a problem hiding this comment.
Need compare every bytes, not just compare the reference
AElf.Kernel/Hash.cs
Outdated
|
|
||
| public int Compare(Hash<T> x, Hash<T> y) | ||
| { | ||
| if (x.ToString() == y.ToString()) |
AElf.Kernel/IAccountDataProvider.cs
Outdated
| @@ -6,7 +6,7 @@ namespace AElf.Kernel | |||
| /// <summary> | |||
| /// Data is stored associated with Account | |||
| /// </summary> | |||
| public interface IAccountDataProvider | |||
| public interface IAccountDataProvider : ISerializable | |||
There was a problem hiding this comment.
Data Provider is a Driver, should not be ISerializable, it's just a tool for data access
|
💸💴💵💰 |
|
вт, 6 февр. 2018 г. в 00:05, samsoull <notifications@github.com>:
💸💴💵💰
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#40 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AiRYj1xpanznW0vY5cCukhSZ1liWbdRjks5tR3spgaJpZM4R2wLq>
.
Thanks!!
|
|
Thank you for subscribing me |
suwarsomno
referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And slightly modify the structure about Block.