Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransactionResult optimization #3626

Merged
merged 36 commits into from
Dec 4, 2024
Merged

Conversation

JimAelf
Copy link
Collaborator

@JimAelf JimAelf commented Dec 4, 2024

add a new method GetTransactionResultV2Async

eanzhao and others added 30 commits November 9, 2024 13:22
2. Add an execution limit for inline transactions
3. Improve compatibility in inline method validation.
…igger that 512, this transaction will never bee succeed in the future
…optimization

Transaction status result optimization
chopin-fan and others added 6 commits November 26, 2024 14:38
Copy link

vizipi bot commented Dec 4, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
96.67% chopin.fan 90 29
66.67% eanzhao 86 20
60.00% jason-hoopox 88 18
60.00% ZhangXin 82 18
46.67% gldeng 28 14
40.00% kaiwenzhengaelf 45 12

Potential missing files from this Pull request

No commonly committed files found with a 40% threashold


Committed file ranks

(click to expand)
  • 97.89%[protobuf/token_contract_impl.proto]
  • 20.99%[...src/AElf.Kernel.SmartContract/InlineWithTransactionIdCoun]
  • 94.83%[...src/AElf.WebApp.Application.Chain/Services/TransactionRes]
  • 77.62%[protobuf/virtual_transaction.proto]
  • 90.80%[src/AElf.Kernel.Core/Extensions/TransactionExtensions.cs]
  • 0.00%[src/AElf.Runtime.CSharp/TransactionConsts.cs]
  • 99.60%[...src/AElf.Kernel.SmartContractExecution/Application/BlockE]
  • 71.47%[test/AElf.Contracts.TestContract.VirtualAddress/Action.cs]
  • 99.57%[azure-pipelines.yml]
  • 99.13%[...test/AElf.Contracts.MultiToken.Tests/MultiTokenContractTe]
  • @JimAelf JimAelf merged commit 4926267 into feature/transaction-result-optimize Dec 4, 2024
    7 of 15 checks passed
    JimAelf added a commit that referenced this pull request Dec 4, 2024
    …optimize
    
    Merge pull request #3626 from AElfProject/dev
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants